Review Request: Add support for selecting a few timezones in digital clock

[Rafał Miłecki]

> On 2008-03-18 20:48:57, Sebastian Kuegler wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp, line 140
> > <http://mattr.info/r/320/diff/1/#file1276line140>
> >
> >     There's a patch on review board that probably goes in, it adds a slot updateTool() (IIRC), so you only do that when necessary. That spares some CPU cycles.

Well, it isn't really usefully for us as long as some people use "Show seconds". We have to keep time in tooltip updated. Making it uptodate just once, when tooltip is going to be shown won't give a nice effect cause seconds won't "move".

There was a nice discussion on mailing list about way of updating time: http://mail.kde.org/pipermail/panel-devel/2008-March/008813.html


- Rafał


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/320/#review312
-----------------------------------------------------------


On 2008-03-18 17:17:52, Rafał Miłecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/320/
> -----------------------------------------------------------
> 
> (Updated 2008-03-18 17:17:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch prepare digital clock for displaying a few timezones.
> 
> 1) It adds QComboBox to let user set main timezone. This timezone will be used to display time in tray and on top of tooltip
> 2) It saves a list of choosen timezones
> 3) It's ready to display a few timezones in tooltip
> 
> To complete support for multiple timezones we need only change selecion mode inside KTimeZoneWidget. Althought I have to make some research about
> void TimeZoneWidget::setSelected (const QString & zone, bool selected);
> as I think it may containg bug. Nevertheless patch for digital clock stays 90% ready.
> 
> 
> This addresses bug 156314.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clockConfig.ui
> 
> Diff: http://mattr.info/r/320/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Digital clock UI after this patch
>   http://mattr.info/r/320/s/37/
> Digital clock later, when I check out (fix?) KTimeZoneWidget and when we enable MultiSelection
>   http://mattr.info/r/320/s/38/
> 
> 
> Thanks,
> 
> Rafał
> 
>