Review Request: desktop containment switching. another try at the setScreen function

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/304/#review305
-----------------------------------------------------------


quick commment on one of the FIXMEs in there.


/trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
<http://mattr.info/r/304/#comment218>

    sure ... functionally it's equivalent right now, aside from the signal emissions. this code predates View which is why it wouldn't be using any of that API.


- Aaron


On 2008-03-17 16:59:00, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/304/
> -----------------------------------------------------------
> 
> (Updated 2008-03-17 16:59:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/view.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.h
> 
> Diff: http://mattr.info/r/304/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>