[PATCH] Bug 158444: Pager can't display name of desktop

[Aaron J. Seigo]

On Thursday 13 March 2008, Rafał Miłecki wrote:
> 2008/3/12, Aaron J. Seigo <aseigo at kde.org>:
> > cool =) i look forward to seeing the update.
>
> It's ready. Thanks for your tip about casting enum<->int. I wasn't
> sure which style of enum should I use. Some apps in KDE use UPPER_CASE
> values and other use First_letter_upper_only.

usually UPPER_CASE is used for literal constants (e.g. "static const int 
FOO;"), and FirstLetterUpper for enums.

> Hope it doesn't matter 
> so much and patch may be accepted. Finally I used:
> enum DisplayedText
> {
> Number,
> Name,
> None
> };

probably good enough. for libraries (which you may end up touching if you hang 
around us crazy plasma people long enough ;) we'd probably do DisplayNumber, 
DisplayName and DisplayNone since that's more obvious when read in code and 
has a lesser likliehood of name collisions should future enums be desirable.

anyways, looks good. go for it =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080313/54444e4d/attachment.pgp