Review Request: Moving of plasmoids on panel

[Stephan Binner]

> On 2008-03-07 14:22:01, Aaron Seigo wrote:
> > Containment is the wrong place for this kind of funcationality. it's very specific to the type of panel based containment we have.
> 
> Marco Martin wrote:
>     but wouldn't it apply also to other hypotetic containments that don't have a free layout?
> 
> Aaron Seigo wrote:
>     not necessarily. Containment has very little knowledge (purposefully) about the contents of the containment. it does provide some very basic code in there, some of which (such as, tbh, the layout creations) needs to be moved out.
>     
>     a random collection of end goals that should be possible would include a MacOS Dock clone, a Windowmaker clip and dock, the control panel from the start ship Enterprise. ok, maybe not the latter, but you get the picture ;)

Uploaded a new patch which should place the implementation correctly.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/261/#review259
-----------------------------------------------------------


On 2008-03-10 08:38:37, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/261/
> -----------------------------------------------------------
> 
> (Updated 2008-03-10 08:38:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Simple implementation to allow rearranging of plasmoids on panels (#154119).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>