Review Request: Option to tile SvgPanel center element

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/268/#review271
-----------------------------------------------------------

Ship it!


two minor points, the second one being the more important of the two. other 'n that, go for it =)



/trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.cpp
<http://mattr.info/r/268/#comment203>

    since these vars are only used within the rendering method, there's no reason to store them in the Private class. moving them to the most local block possible should be good enough.



/trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.cpp
<http://mattr.info/r/268/#comment202>

    instead of !tileCenter, can you swap the two blocks so we have 'if (tileCenter)' ... it's a minor thing, but making the code as easy to read as possible is a nice thing =)


- Aaron


On 2008-03-08 03:07:44, Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/268/
> -----------------------------------------------------------
> 
> (Updated 2008-03-08 03:07:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I was hoping to do some mesh backgrounds, or similar patterned backgrounds, for Plasma themes (think iphone home screen panel).  I was struggling with the current implementation which stretches the center element.  So I'm proposing this patch to also allow tiled center element.
> 
> It requires the use of presence of a "hint-tile-center" element similiar to the existing "hint-stretch-borders" element.  Sorry if this is adding yet another hint, but it seemed to provide the most flexibility.  This also implies that the center element will be stretched by default, as it currently is.  I could switch it to mimic the border behaviour, which tiles by default, but it might break whatever themes will be created for the 4.0.x branches.
> 
> Hope this is helpful.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.cpp
> 
> Diff: http://mattr.info/r/268/diff
> 
> 
> Testing
> -------
> 
> Did a quick mod of the default theme background for testing.  The screenshot shows the different size applets with tiled, instead of stretched, background.  Again, just a proof-of-concept.  Yes, it could look better.
> 
> 
> Screenshots
> -----------
> 
> quick mod of default background
>   http://mattr.info/r/268/s/33/
> 
> 
> Thanks,
> 
> Andrew
> 
>