Review Request: Kickoff: Add Calculator Search

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/264/#review263
-----------------------------------------------------------


+1 on the idea, but does it make sense to implement these in every single applet that wants such features? that is the point of AbstractRunner. the CalgulatorRunner should be used here, and it has got to be faster than looking for "bc" in the path =)

it'll also keep greater consistency between krunner, kickoff and whatever other components come in the future with a similar pattern.

- Aaron


On 2008-03-07 07:46:43, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/264/
> -----------------------------------------------------------
> 
> (Updated 2008-03-07 07:46:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Brings back the calculator functionality of Kickoff/3.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/searchmodel.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/searchmodel.cpp
> 
> Diff: http://mattr.info/r/264/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>