Review Request: Themed task item backgrounds

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/262/#review257
-----------------------------------------------------------

Ship it!


this is a good thing, also because it permits to experiment a little bit more (at the moment the contrast of the selected task is really weak)

only a little thing: since the tasks won't have always the same aspect ratio the rounded borders could appear deformed
they usually don't have a very different ratio so maybe it will not be much noticeable.
an other option would be using SvgPanel, but at the moment it only supports a single items per file, so 3 files would be needed
another option would bemodifying PanelSvg to be able to manage multiple items per file.

even having raised that concern, i would go with your patch for now, because it looks way simpler (and gradients are veery difficult to make them look decent with SvgPanel)

- Marco


On 2008-03-07 02:31:34, Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/262/
> -----------------------------------------------------------
> 
> (Updated 2008-03-07 02:31:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch allows task item backgrounds to be painted using a theme svg file.  The svg file used widgets/tasks.svg and should contain the following elements: focus, hover, attention and normal.  If the svg file is absent then the backgrounds are painted as they do currently.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h
> 
> Diff: http://mattr.info/r/262/diff
> 
> 
> Testing
> -------
> 
> Tested with simple proof-of-concept tasks.svg available here: http://www.mediafire.com/?1k1zjk3nu3d
> 
> No problems that I noticed.
> 
> 
> Thanks,
> 
> Andrew
> 
>