Review Request: Moving of plasmoids on panel

Will Stephenson wstephenson at kde.org
Fri Mar 7 09:18:06 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/261/#review255
-----------------------------------------------------------


It's ok, but you can only change the relative position of applets with it.  If you have an empty panel there are no other applets to exchange position with, so you can't move them to the other end of the panel (tested with horizontal and vertical panels).

A rather random observation: An implementation that would work with non-panel containments could delegate the relayout to the layout, by passing the hoverevent and the applet sizes to the layout, and saying "you figure out where this should go and where the other contents have to move to". 

- Will


On 2008-03-06 16:13:31, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/261/
> -----------------------------------------------------------
> 
> (Updated 2008-03-06 16:13:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Simple implementation to allow rearranging of plasmoids on panels (#154119).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.h
> 
> Diff: http://mattr.info/r/261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>



More information about the Panel-devel mailing list