Review Request: rounded borders to dialogs

[Marco Martin]

> On 2008-03-05 08:18:30, Luboš Luňák wrote:
> > There's no need to make the shape optional only when compositing is disabled - just because compositing hides the problem that doesn't mean the problem is not there.
> >
> 
> Marco Martin wrote:
>     but making shaped windows with compositing wouldn't it mean to not being able to make antialiased borders?
> 
> Luboš Luňák wrote:
>     No, that'd mean that the shape is not right :). Why do you think the shape can be ignored just because you can't see it? You still won't be e.g. able to click through parts that are "not" there.
>

ok, for this i have an idea, that i began to implement but i would like to know if it's too wrong or not before going any further:
the window mask is generated from the panelsvg class with a qbitmap generated from the alpha channel of the rendered svg (and it would be ok for both compositing or not because only pixels with alpha=0 are left out the mask)
the problem is that without compositing the rounded borders appears a little bit dirty (eh, damn antialiasing:D) so a proper svg with pixelated borders in the "opaque" set would be needed.
Any thoughts?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/258/#review240
-----------------------------------------------------------


On 2008-03-05 07:34:28, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/258/
> -----------------------------------------------------------
> 
> (Updated 2008-03-05 07:34:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes rounded borders to dialogs when compositing is not active just like the tooltips.
> -since the check if compositing is active is done in many places i added it to Plasma::Theme since it was already keeping track of it (does this makes sense?)
> -tooltips had a rounded borders radius hardcoded of 10px, i made a new svg element (and consequent access functions in svgpanel) hint-round-radius to retrieve the size for pixmap based svgs it must be something like an external square, for vector based it could be an element inner to for instance the topleft corner id
> -krunner is still missing, i've not touched it atm since is in the process of becoming "good enough for aaron"(tm) :P
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/svgpanel.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/opaque/dialogs/background.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/opaque/widgets/tooltip.svg
> 
> Diff: http://mattr.info/r/258/diff
> 
> 
> Testing
> -------
> 
> tested tooltips and some dialogs also with svg that don't have the hint-round-radius element: they simply become squared
> 
> 
> Thanks,
> 
> Marco
> 
>