Review Request: New scene placement strategy for PanelContainments

Andre Duffeck duffeck at kde.org
Wed Mar 5 10:03:09 CET 2008



> On 2008-03-05 02:24:03, Andre Duffeck wrote:
> > It basically works with my xinerama setup, but i noticed 2 glitches.
> > 
> > 1. There is a 1px thin white border on the panel. For left, top and right panel positions it is on the bottom, if the panel is on the bottom it is on the top of the panel.
> > 
> > 2. After switching the panel formfactor (using the panel configuration dialog), the panel goes completely white. It can be fixed by changing the position then.

Scratch #1, it's not related to this patch apparently.

I noticed another issue, though. Resizing the panel (on-the-fly using the panel configuration dialog again) is broken, the position of the contents is wrong and there are white/empty areas instead.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/256/#review238
-----------------------------------------------------------


On 2008-03-05 01:21:38, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/256/
> -----------------------------------------------------------
> 
> (Updated 2008-03-05 01:21:38)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently panels are stacked in a logical ordering according to where they physically appear on a given screen. This makes multiple panels, moving panels around, etc more complicated while also making xinerama easy to break.
> 
> This patch changes the strategy completely since views do not actually pay attention to the scene position of the containment relative to the screen to position themselves. The strategy in this patch is to stack all horizontal panels one atop the other and all vertical panels side by side 10k pixels to the right.
> 
> Non-full width panels and non-flush-left/top panels will be accomodated by positioning them vertically / horizontally along the approriate axis. This doesn't interfere with stacking, and so continues to make growing / sliding containments cheap.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> 
> Diff: http://mattr.info/r/256/diff
> 
> 
> Testing
> -------
> 
> Single screen only with: one panel; two horizontal panels; one horizontal panel and one vertical panel. All four screen edges tested.
> 
> Needs testing on xinerama/mergefb set ups.
> 
> 
> Thanks,
> 
> Aaron
> 
>



More information about the Panel-devel mailing list