Review Request: New scene placement strategy for PanelContainments

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/256/
-----------------------------------------------------------

(Updated 2008-03-05 01:21:38.218615)


Review request for Plasma.


Summary
-------

Currently panels are stacked in a logical ordering according to where they physically appear on a given screen. This makes multiple panels, moving panels around, etc more complicated while also making xinerama easy to break.

This patch changes the strategy completely since views do not actually pay attention to the scene position of the containment relative to the screen to position themselves. The strategy in this patch is to stack all horizontal panels one atop the other and all vertical panels side by side 10k pixels to the right.

Non-full width panels and non-flush-left/top panels will be accomodated by positioning them vertically / horizontally along the approriate axis. This doesn't interfere with stacking, and so continues to make growing / sliding containments cheap.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
  /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp

Diff: http://mattr.info/r/256/diff


Testing
-------

Single screen only with: one panel; two horizontal panels; one horizontal panel and one vertical panel. All four screen edges tested.

Needs testing on xinerama/mergefb set ups.


Thanks,

Aaron