Review Request: fix border calculation by positioning panels based on their location

[Aaron Seigo]

> On 2008-03-02 00:51:04, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp, line 129
> > <http://mattr.info/r/238/diff/1/#file707line129>
> >
> >     the point of using the screenRect is to take into consideration multiple screens. we place containments above the screen they are associated with. so this line breaks with two screens and a panel on the second screen.
> 
> Chani Armitage wrote:
>     no it doesn't. the panel's geometry does *not* take into account the translation into negative space. so a panel at the top will think it's at 0,0 no matter what screen it's on.
> 
> Chani Armitage wrote:
>     now I wish there was a 'delete comment' button. ;) I was wrong.

with http://mattr.info/r/256/ this part of the patch becomes correct. so if 256 goes in, you should probalby commit the border parts of the patch.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/238/#review229
-----------------------------------------------------------


On 2008-03-01 22:42:31, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/238/
> -----------------------------------------------------------
> 
> (Updated 2008-03-01 22:42:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/238/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>