Review Request: Fix compilation of Kickoff with picky g++ versions

Aaron Seigo aseigo at kde.org
Tue Mar 4 18:06:32 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/253/#review236
-----------------------------------------------------------


i've committed a slightly easier fix: wrapping the whole implementation in a namespace Kickoff {} block. this way if/when new methods are added to this class, we don't end up with the problem again =)

- Aaron


On 2008-03-04 10:22:52, Marijn Kruisselbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/253/
> -----------------------------------------------------------
> 
> (Updated 2008-03-04 10:22:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch fixes errors like: /.../kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp:119: 
>              error: 'ApplicationModelPrivate' has not been declared
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
> 
> Diff: http://mattr.info/r/253/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marijn
> 
>



More information about the Panel-devel mailing list