Review Request: disable toolbox for now

Aaron Seigo aseigo at kde.org
Mon Mar 3 17:18:20 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/241/#review232
-----------------------------------------------------------


sorry, this isn't going to happen. we've discussed this thoroughly.

http://bugs.kde.org/show_bug.cgi?id=154535

you can, of course, put this patch in your downstream builds. you'll be doing the project a disservice, however. or are we not actually developing software in the open anymore but only delivering a final product and therefore completely avoiding the entire feedback cycle? if so, show me where our new Q/A and usability labs are where we can send features for testing and review.

having this toolbox there has allowed us to find and fix bugs in 4.0.x. for whatever reason, people seem to think that's a bizarre goal to have. 

it also will grow into something that has clearer purpose. disabling it now just means more code maintenance and far less testing. i'm concerned it will also scuttle future work on it.

the issues with it are afaik fixable. and many of the complaints are complete BS (such as the "it interferes with closing my window!" it doesn't).

btw, context menus are hidden features (hello usability!) that tend to only work nicely in a two button mouse world (hello touch screens!).

minor issue: the patch doesn't follow the coding style.

- Aaron


On 2008-03-03 10:04:51, Dirk Mueller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/241/
> -----------------------------------------------------------
> 
> (Updated 2008-03-03 10:04:51)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch disables the toolbox by default - which up to my knowledge does not provide any useful feature other than "Add Widget" in KDE 4.0.x. "Add Widget" is however already available via the desktop context menu. It seems from the openSUSE feedback, the toolbox confuses users (especially when they shrink their wallpaper with it). 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> 
> Diff: http://mattr.info/r/241/diff
> 
> 
> Testing
> -------
> 
> started plasma with the patch, confirmed that it does not crash
> 
> 
> Thanks,
> 
> Dirk
> 
>



More information about the Panel-devel mailing list