review of trashcan

Aaron J. Seigo aseigo at kde.org
Sun Mar 2 19:09:12 CET 2008


On Sunday 02 March 2008, Marco Martin wrote:
> Hi,
> it's quite a some time the trashcan applet is in kdereview, now i think
> it's working pretty well.
> is there still some issues in the code i am not aware or i have forgotten
> that must be addressed before moving to kdebase?

no, i think it's ready to go.

> the only thing i am aware of and it's really ugly is
> http://bugs.kde.org/show_bug.cgi?id=155763
> that i really don't know what to do about it :(
> so wait until it's fixed? find a workaround? commit anyways?

commit anyways. it's not a bug in your code, and exposing it to more air will 
increase its likelihood of getting fixed.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080302/305ccc08/attachment.pgp 


More information about the Panel-devel mailing list