Review Request: properly remove m_size var from panel code [now with geometryChanged signal]

Chani Armitage chanika at gmail.com
Sat Mar 1 06:01:34 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/219/
-----------------------------------------------------------

(Updated 2008-02-29 23:01:34.388738)


Review request for Plasma.


Summary (updated)
-------

this completely removes m_size. I introduced a few functions to keep things clear. there is a small change in behaviour - the config dialog now shows the full size of the panel, including the borders.
this might horribly break with multiple screens, I'm not sure. please test.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
  /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp

Diff: http://mattr.info/r/219/diff


Testing
-------


Thanks,

Chani



More information about the Panel-devel mailing list