[Bug 164949] New: Folder View does not perform timely repaint when drag does remove file

[David Benjamin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164949         
           Summary: Folder View does not perform timely repaint when drag
                    does remove file
           Product: plasma
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: widget-folderview
        AssignedTo: panel-devel kde org
        ReportedBy: dnas.dnas gmail com


Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

When dragging an icon from a Folder View where the drag does not remove the file (e.g. to the Frame applet or creating a link), the icon does not get repainted until hover.

Patch below results in a repaint regardless of the result of the drag. Alternatively, if (result != Qt::MoveAction) could be used, but I don't know if it's possible to get a Qt::MoveAction and not actually remove the file. A confused client or moving into the same folder, perhaps?


Index: folderview.cpp
===================================================================
--- folderview.cpp      (revision 824074)
+++ folderview.cpp      (working copy)
 @ -1399,10 +1399,8  @

     m_dragInProgress = false;

-    // Repaint the dragged icons if the drag was canceled
-    if (result == Qt::IgnoreAction) {
-        markAreaDirty(boundingRect);
-    }
+    // Repaint the dragged icons in case the drag did not remove the file
+    markAreaDirty(boundingRect);
 }

 QSize FolderView::iconSize() const