KDE/kdebase/workspace/plasma/applets/systemtray

[Aaron J. Seigo]

On Monday 09 June 2008, Jason Stubbs wrote:
> On Monday 09 June 2008 10:15:21 JST, Sebastian Sauer wrote:
> > SVN commit 818620 by sebsauer:
> >
> > fix GTK icons are painted bigger than KDE icons in the systemtray.
> >
> > ---
> > trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtraycontainer
> >.c @@ -42,9 +42,7 @@
> >      updateBackground();
> >
> >      // Tray icons have a fixed size of 22x22
> > -    setMinimumSize(22, 22);
> >      setMaximumSize(22, 22);
> > -    resize(22, 22);
> >  }
> >
> >  void SystemTrayContainer::embedSystemTrayClient( WId clientId )
> > ---
> > trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtraywidget.cp
> >p @@ -125,7 +125,9 @@
> >  void SystemTrayWidget::addWidgetToLayout(QWidget *widget)
> >  {
> >      // Add the widget to the layout
> > -    m_mainLayout->addWidget(widget, m_nextRow, m_nextColumn);
> > +    m_mainLayout->setRowMinimumHeight(m_nextRow, 22);
> > +    m_mainLayout->setColumnMinimumWidth(m_nextColumn, 22);
> > +    m_mainLayout->addWidget(widget, m_nextRow, m_nextColumn, 1, 1,
> > Qt::AlignCenter);
> >
> >      // Figure out where the next widget should go
> >      if (m_orientation == Qt::Horizontal) {
>
> Just out of interest, don't these additions and removals lead to exactly
> the same behaviour? Also, the centering indicates that the widget can have
> a size less than 22x22; is that the case?

because i hate the system tray i've been trying to stay out of it ;)

but what one *really* wants to do is let each icon take as much room as it 
wants. even if the base block size is 22x22 in the layout, tray items will 
need to span multiple cells if need be to fit them in their entirety.

but as i'm probably not going to write that code, i'll just shut up now ;)

btw, Jason, you have a number of open "Ship It" patches on review board at 
http://reviewboard.vidsolbach.de/dashboard/ ... would it be possible to commit 
or mark them as submited if they already are committed? thanks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080609/a7c4b03b/attachment.pgp