[PATCH] Add the missing context menu to the folderview applet

[Aaron J. Seigo]

On Sunday 08 June 2008, Fredrik Höglund wrote:
> But it would actually be possible to do the reverse by adding actions
> from the standard menu to the Konq menu.

this is what the standard menu items do when they are given more than 2 
actions to integrate... it puts the actions returned by the item into the main 
menu and creates a submenu for the standard actions at the bottom.

> > the only input i have is that it probably makes sense to delay
> > initialization of the KNewMenu and not call createAction() until that
> > stuff is actually needed (in showContextMenu, i imagine)
>
> I'm not sure how expensive it is in practice, but I'll do that.

thanks =) it's just good practice; otherwise we end up with some things pre-
allocated, others not and we have to constantly think about it. i prefer to 
keep a single strategy, with exceptions only when needed.

> > i really do like how the implementation detail of having a
> > KActionCollection in Applet::Private is kept out of the public API,
> > though ... perhaps if we run into more such situations in applets we'll
> > have to rethink that. for this case, though, i don't think there's enough
> > reason to adjust the Applet API yet.
>
> Yeah, exposing a pointer to the action collection seems like bad
> API design.

yep ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080608/546cec25/attachment.pgp