[PATCH] Add the missing context menu to the folderview applet

[Aaron J. Seigo]

On Thursday 05 June 2008, Fredrik Höglund wrote:
> This patch adds an implemention of the context menu for the icons to the

awesome =)

> folderview applet, and also adds the familiar "Create New", "Undo", and
> "Paste" actions to the applet's context menu.

cool; it's a bit unfortunate that the konq menu can't also be fetched as a set 
of actions so plasma could merge it with the standard menu. oh well, not a 
huge loss.

the only input i have is that it probably makes sense to delay initialization 
of the KNewMenu and not call createAction() until that stuff is actually needed 
(in showContextMenu, i imagine)



it's also a bit unfortunate that you have to have your own action collection 
there. there's already one in Applet and it's accessible by addAction and 
action ..... we just don't provide direct access to the KActionCollection*, 
which you need for the KonqPopupMenu ctor. hum...

i really do like how the implementation detail of having a KActionCollection 
in Applet::Private is kept out of the public API, though ... perhaps if we run 
into more such situations in applets we'll have to rethink that. for this 
case, though, i don't think there's enough reason to adjust the Applet API 
yet.

> committed.  The apps module will get an optional dependency on plasma,

bwuhahaha. another module infected! ;-P

> and unfortunately a side effect of this is that it will not be possible to
> have icons on the desktop without installing apps.  But it seems unlikely
> that someone would only want workspace and runtime, so in practice
> this shouldn't be a problem.

agreed.


p.s. http://reviewboard.vidsolbach.de/dashboard/ =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080605/78b4b83c/attachment.pgp