KDE/kdebase/workspace/plasma/applets/kickoff/core

[David Faure]

On Sunday 13 January 2008, Bill Egert wrote:
> --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/models.cpp #760860:760861
> @@ -40,8 +40,8 @@
>  
>  using namespace Kickoff;
>  
> -static KUrl homeUrl(getenv("HOME"));
> -static KUrl remoteUrl("remote:/");
> +static const KUrl homeUrl(getenv("HOME"));
> +static const KUrl remoteUrl("remote:/");
>  
>  namespace Kickoff
>  {

Eek, global objects in libraries. This leads to crashes in some situations.
Plasma developers: please remove global objects and use either K_GLOBAL_STATIC,
or global plain-old-datatypes (for instance static const char [] is ok), or no file-global object at all.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).