[PATCH] check for valid user input in FifteenPuzzle

[Thomas Coopman]

On Jan 23, 2008 10:10 PM, Andre Magalhaes <andrunko at gmail.com> wrote:
> 2008/1/23 Thomas Coopman <thomas.coopman at gmail.com>:
> > Hi,
> >
> > This patch checks if the user enters a valid file (checks if the file exists).
> >
> > Also if the pixmap cannot be loaded it uses the default pixmap.
> I committed it as the bug was caused because of my config changes.
> I did some small changes to check if the file is a valid pixmap and some
> indentation issues (Please do not use tabs, use spaces instead)

Oops, forgot to change that in kate in kde4.
>
> > The patch also contains support for selecting background and
> > foreground colors (as previously send but it now uses the old default
> > colors)
> > I can remove that if necessary
> I didn't commit this part as I didn't like it that much.
> Here are my reasons:
> - The Text/Shadow Color widgets are misplaced, the texts are left aligned and
> the color selectors are right aligned.
> - The color selectors are too small and too distant from the
> corresponding labels
> - The Text/Shadow Color label and color selectors should be disabled
> if "Use custom image"
> is selected and "Show Numerals" are not.

Ok, I understand, maybe I'll do some more work on it later to improve it.
>
> BR

Thanks for looking at it
>
> --
> Andre Moreira Magalhaes (andrunko)
> --------------------------------------------------------
> Jabber: andrunko at gmail.com
> MSN:   andremoreira at msn.com
> Skype:  andrunko
> Blog:    http://andrunko.blogspot.com
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>



-- 
Thomas Coopman
Thomas.coopman at gmail.com