[PATCH] Fifteen puzzle config revamp

[Jesper Thomschutz]

Hi,
Feel free to make use of the wonderful world of OSS and improve the code as you see fit :)
I appreciate the improvements that you guys are making to this applet.

Jesper, the neglecting father of the fifteen puzzle plasmoid


----- Original Message ----
From: Andre Magalhaes <andrunko at gmail.com>
To: panel-devel at kde.org
Sent: Tuesday, January 22, 2008 8:44:34 PM
Subject: Re: [PATCH] Fifteen puzzle config revamp


2008/1/22 Chani <chanika at gmail.com>:
>
> +    while (m_pieces.at(rand) != NULL) {
> +      rand = qrand() % 16;
> +    }
>
> this... looks... Bad.
> I hate seeing any loop that has a random ending condition... what if
 it never
> finishes?
> but I don't know the context, and it's past my bedtime so I'm just
 gonna skip
> down to... oh! you already used configNeedsSaving() - awesome. :)
>
Yeah, I don't like this also, but this is not my code, and I didn't
touch it (besides
reindent it).
I tried to just fix the config dialog, and add the possibility to save
the config options.
Maybe this can be discussed with the applet "owner".

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com
_______________________________________________
Panel-devel mailing list
Panel-devel at kde.org
https://mail.kde.org/mailman/listinfo/panel-devel






      ____________________________________________________________________________________
Looking for last minute shopping deals?  
Find them fast with Yahoo! Search.  http://tools.search.yahoo.com/newsearch/category.php?category=shopping
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080122/4ca108cd/attachment.html