[PATCH] Fifteen puzzle config revamp

[Hans Chen]

Hi again Andre,

You're really doing a great work! (only judged by screenshots). The area I
personally think needs more work in KDE is on polishing. I really appreciate
small improvements like this only, it makes the whole experience much much
better.
I really wish I had more time, these kind of jobs seem like a good
introduction to KDE programming. Oh well, now back to topic.

> I  also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).

When I saw the screenshots I was going to suggest this. In my opinion the
button belongs to a configuration dialog. I was thinking why it was there,
and not only in the right-click menu, and I think I have an answer:
discoverability. Yeah, actually you don't have to right click to bring up
the configure dialog which I thought first.

I don't know if that's a good reason though, personally I would just access
the action from the right click menu.

With best regards,
Hans Chen

2008/1/22 Andre Magalhaes <andrunko at gmail.com>:

> Hi all,
>
> Here I am again. I am trying to get the config dialogs in a sane state.
> Another config dialog that was pissing me off was the Fifteen puzzle
> config dialog
> so I rewrote it.
>
> The code now besides the visual improvement, saves config options,
> so when you reload the applet it will use the saved options.
> I also reindented some part of the code to follow the applets code
> indentation
>
> Eg.: Added {  } to all if, while, for ...
>       Removed trailing whitespaces
>       ...
>
> Here are the screenshots of the old and new config dialog:
>
> Old config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773400/
> Old config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773404/
> Old config when "Plain .." option is selected again:
> http://www.flickr.com/photos/andrunko/2212773406/
>
> New config in the initial state:
> http://www.flickr.com/photos/andrunko/2212773410/
> New config when "Split ..." option is selected:
> http://www.flickr.com/photos/andrunko/2212773414/
>
> I  also added an action in the menu to shuffle the pieces.
>
> There is only one remaining issue in the new config dialog. I don't think
> a shuffle pieces button should be there, but I can't find a way to do
> it but in the menu (already added in the patch).
>
> Any feedback is welcome, if everybody agrees I will commit it.
>
> BR
>
> --
> Andre Moreira Magalhaes (andrunko)
> --------------------------------------------------------
> Jabber: andrunko at gmail.com
> MSN:   andremoreira at msn.com
> Skype:  andrunko
> Blog:    http://andrunko.blogspot.com
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080122/0e98bb70/attachment.html