Removal of Plasma::Dialog::position()

Marco Martin notmart at gmail.com
Tue Jan 22 17:37:44 CET 2008


On Tuesday 22 January 2008, Aaron J. Seigo wrote:
> On Tuesday 22 January 2008, Marco Martin wrote:
> > so now i think it could be killed and this raises the following
> > questions: is still needed for something that i didn't take into account?
>
> they do look to be identical. the only difference is how they get the view
> and therefore the positions.
>
> my suggestion would be to keep Dialog::position (well, rename it to
> popupPosition) and Widget::popupPosition and move the common calculations
> to Plasma::popupPosition which Dialog and Widget can then call.

but there is still the need of it?
and would still the api be different? widget needs the dialog size and dialog 
the widget size
not totally convinced...

Cheers,
Marco Martin


More information about the Panel-devel mailing list