[Bug 152696] panel cannot be repositioned / resized

[Aaron J.Seigo]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=152696         




------- Additional Comments From aseigo kde org  2008-01-13 06:10 -------
cool patch; the coding style looks fine. a couple of comments:

* you have a dialog and a kconfigxt object. here's what's really cool: you can skip all the setting of values if you just name the widgets the same as the kconfigxt items and prefix them with kcfg_ .. so instead of heightSpinBox kcfg_Height. 

* i usually don't add the type of widget to the name (heightSpinBox) because then when you change the widget later .. sucks. =) it also doesn't work nicely with kconfigxt

* unfortunately, this uses a separate config file. that's a no-go. sadly kconfigxt hasn't been updated to work with KConfigGroup objects, so that needs to get done in kdelibs.

* i'm really unconvinced we want the width in %. we need a special value for full width, but other than that i think pixel values are easier to manage, tbh.

* anchor points are missing (flush left, flush right, pixel x) as are expanding directions, but as you note this is not a full patch

* you don't delete the config dialog in the dtor so you have a memory leak =)

* interesting gotcha that pretty much everyone misses: if the dialog is already created, then you move desktops, the dialog will show on the desktop it was last on not necessarily the current desktop. it may also be under other windows. you can fix this with:

KWindowSystem:::setOnDesktop(m_dialog->windId(), KWindowSystem::currentDesktop()));
KWindowSystem::activateWindow(m_dialog->windId());

long term we don't want to do this with a dialog anyways, but provide a toolbox on the panel sort of like the desktop one.

thanks for the patch all the same, i hope you enjoyed working on it (that's the best reason to do it, after all =). if you want to keep hacking on plasma stuff (it has a way of being slightly addictive ;) please consider joining the panel-devel kde org mailing list if you haven't already.