[Panel-devel] [PATCH] tooltips + taskbar thumbnails

[Jason Stubbs]

On Tuesday 08 January 2008 01:54:09 Lubos Lunak wrote:
> On Monday 07 of January 2008, Jason Stubbs wrote:
> > On Monday 07 January 2008 19:54:38 JST, Lubos Lunak wrote:
> > > On Sunday 06 of January 2008, Jason Stubbs wrote:
> > > > On Sunday 06 January 2008 23:00:24 JST, Lubos Lunak wrote:
> > > > > Dne Sunday 06 of January 2008 04:09:18 Jason Stubbs napsal(a):
> > > > > > In my experience, it always appears instantly but never in the
> > > > > > right position. I've attached an example but the position and
> > > > > > size change each time the tooltip is shown.
> > > > >
> > > > >  Can you provide more details?
> > > >
> > > > I've attached snapshots of three more examples of how it appears.
> > >
> > > ...
> > >
> > > > Anything else that might prove useful?
> > >
> > >  I cannot reproduce. Check in WindowPreview::setInfo() in
> > > workspace/libs/plasma/widgets/tooltip.cpp whether the position passed
> > > to KWin is correct. If not, there's a bug with layouts somewhere, if
> > > yes, please try to find out which KWin effect is causing it.
> >
> > Three hours and a -3/+4 patch later... I am now getting thumbnails. :)
> >
> > The format parameter to XChangeProperty seems to have the wonderful
> > property that 32 means sizeof(long) even though 8 and 16 mean 8-bit and
> > 16-bit respectically. The attached patch fixes the assumption that 32
> > means 32-bit in code paths used by the tooltip thumbnails effect, but
> > there may be more lurking elsewhere.
>
>  Ah, damn, so lame from me, thanks for the patch. It should be fine in
> other places, I usually don't forget about this ... speciality.

No worries. It gave me a chance to learn about something other than plasma and 
increased my very limited Xlib knowledge at the same time. :)

I'll commit when I get home then, if you haven't already.

-- 
Jason Stubbs