KDE/kdebase/workspace/libs/plasma

[Jason Stubbs]

On Sunday 06 January 2008 04:45:02 JST, Aaron J. Seigo wrote:
> On Saturday 05 January 2008, Jason Stubbs wrote:
> > SVN commit 757548 by jstubbs:
> >
> > Flush containment constraints as soon as they are loaded so that they can
> > be acted upon without having to wait for the event loop. This is needed
> > so that the desktop doesn't temporarily appear white when a wallpaper
> > hasn't been set.
> >
> >
> >  M  +1 -0      containment.cpp
> >  M  +2 -0      corona.cpp
> >
> >
> > --- trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> > #757547:757548 @@ -146,6 +146,7 @@
> >      setLocation((Plasma::Location)group->readEntry("location",
> > (int)d->location));
> > setFormFactor((Plasma::FormFactor)group->readEntry("formfactor",
> > (int)d->formFactor)); setScreen(group->readEntry("screen", d->screen));
> > +    flushUpdatedConstraints();
> >  }
>
> this is wrong. there's little point in having delayed constraints updated
> if we put this here.

The four constraint changes are still being merged into one notification... Is 
there something else that I'm missing?

> the proper place to do this is in Corona as the rest of your patch did.

That works for me too. The attached patch is fine then?

-- 
Jason Stubbs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-constraints-flush.patch
Type: text/x-diff
Size: 1092 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080106/b529fc15/attachment.bin