KDE/kdebase/workspace

[Aaron J. Seigo]

On Saturday 05 January 2008, Marco Martin wrote:
> SVN commit 757756 by mart:
>
> Make icon applets to work in panel:
> sizehint of icon widget returns size() instead of the stored one to
> preventing returning (-1,-1) for the first time and initialize a size in
> the icon applet
>
>  M  +1 -1      libs/plasma/widgets/icon.cpp
>  M  +1 -0      plasma/applets/icon/icon.cpp
>
>
> --- trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon.cpp #757755:757756
> @@ -343,7 +343,7 @@
>
>  QSizeF Icon::sizeHint() const
>  {
> -    return d->currentSize;
> +    return size();
>  }

have you tested this in all situations, e.g. "naked" icons, the kickoff menu 
button, the logout widget? if so, then currentSize can probably simply be 
removed and size() used everywhere. in any case, sizeHint() does return 
size() by default if there is not managing layout, so this makes 
Icon::sizeHint() completely redundant now (iow: it could just be removed)


-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080105/b9165b3f/attachment.pgp