KDE/kdebase/workspace/plasma/containments/desktop

[Aaron J. Seigo]

On Saturday 05 January 2008, Jason Stubbs wrote:
> Save the config after setting the default wallpaper so it is available for

> --- trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
> #757554:757555 @@ -248,6 +248,7 @@
>          }
>
>          kDebug() << "Setting wallpaper to default" << m_wallpaperPath;
> +        emit configNeedsSaving();

this part probably do what you think it does. this is just about flushing to 
disk. if setting the default wallpaper doesn't set the value in config() then 
there's a problem, otherwise this won't do anything.

what's needed here is:

KConfigGroup cg = config();
cg..writeEntry("wallpaper", m_wallpaperPath);

as a side note: the code can not know *when* the flushing to disk caused by 
configNeedsSaving is going to happen so code must not be written in a way 
that holds any assumptions about that. right now with this code if the user 
were to configure their desktop within the first 2 minutes of plasma this 
call will not have actually done anything yet.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080105/4205686c/attachment.pgp