KDE/kdebase/workspace/plasma/containments/desktop

[Aaron J. Seigo]

On Saturday 05 January 2008, Jason Stubbs wrote:
> SVN commit 757546 by jstubbs:
>
> Set a default wallpaper after constraints have been set so that geometry
> can be used to find the correct sized wallpaper. This also prevents
> updateBackground() from being called twice during startup.

> +    m_wallpaperPath = cg.readEntry("wallpaper", "");

minor nit: QString() should be favoured over "" in code like this.

> +        // Only set the wallpaper if constraints have been loaded
> +        if (screen() != -1) {
> +            updateBackground();
> +        }

this will break for desktop containments that are not assigned to a screen 
(e.g. alternate containments). it's an incorrect assumption that all desktop 
containments will have a screen associated with them and will result in such 
containments not repainting their background when they should. 

i also wonder why you did this for just static and not slideshow backgrounds?

in any case, perhaps a better fix might be add a parameter to reloadConfig 
that tells it whether or not to also call updateBackground. this would be set 
to false or whatever when called from init() but true when called elsewhere.

p.s. this is really on the cusp or even beyond the cusp of the size of patches 
that should be peer reviewed; i assume you had this peer reviewed by someone?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080105/fcd863f1/attachment-0001.pgp