[PATCH] Pretty rectangles around the icons

[Aaron J. Seigo]

On Thursday 03 January 2008, Marco Martin wrote:
> On Thursday 03 January 2008, Aaron J. Seigo wrote:
> > On Thursday 03 January 2008, Marco Martin wrote:
> > > On Thursday 03 January 2008, Aaron J. Seigo wrote:
> > > > On Wednesday 02 January 2008, Marco Martin wrote:
> > > > > this patch adjust the radius of the background rectangle of the
> > > > > icons, and it does not uses the svg anymore.
> > > > > The svg is still used for the icon actions background and in
> > > > > drawForeground() (even if the foreground-hover and
> > > > > foreground-pressed elements are empty at the moment, not had decent
> > > > > ideas for it :D)
> > > >
> > > > you may as well ditch the svg completely then. no point in the
> > > > overhead if we aren't using it for the background. it's a very basic
> > > > svg in there right now anyways, and even if this does completely and
> > > > absolutely screw the idea of making plasma themable, hopefully we can
> > > > fix it after 4.0.
> > >
> > > ok, here is my take: at the moment still leave the svg here and provide
> > > a svg with only action buttons background, so there shouldn't be much
> > > overhead, because drawbackground doesn't use the svg and drawforeground
> > > shouldn't execute at all because svgElements won't have SvgForeground
> > > and the others.
> >
> > seeing as nearly no icons use action buttons and the action button
> > background could just as easily be done with a hardcoded rounded rect
> > being painted as well, i just don't see the point of having that
> > Plasma::Svg object in memory. Plasm::Icon has an insane number of members
> > in the private class these days as it is.
>
> ok, now the svg is removed, can commit? (also delete iconbutton.svg?)

i've seen you've re-tasked the purpose of the element enum, but.. yeah, go for 
it.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080103/344354ea/attachment.pgp