[Panel-devel] [PATCH] Restore composite support in libtaskmanager

[Ryan P. Bitanga]

On 1/2/08, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Tuesday 01 January 2008, Ryan P. Bitanga wrote:
> > Subject says it all. :)
>
> since taskmanager.h is publicly installed, should config-X11.h really be
> included in it? i'd think that would belong in the _p.h or .cpp, no?
Oops my bad.. Was originally in taskmanager_p.h except I noticed
config-X11.h was needed by taskrmbmenu.cpp. Totally slipped my mind.
>
> also, just to confirm i'm not losing my mind here ;) this patch is basically
> just moving around some #defines, correct? what was reason for this (as it's
> not immediately apparent from reading the patch)
Transferring the classes to their own files resulted in task.cpp
missing the defines. I thought it would be cleaner to have a
non-installed header file that included the shared headers/defines.