[Panel-devel] icons, files and the desktop

[Aaron J. Seigo]

On Tuesday 01 January 2008, Marco Martin wrote:
> On 1/1/08, Aaron J. Seigo <aseigo at kde.org> wrote:
> > no, the real problem is in the Plasma::Icon::Private::decoration method.
> > if you look closely you'll notice that it's caching the contents of the
> > svg in there as well. this is probably not needed or desired in this case
> > as we'll need to re-render anyways.
>
> but decoration() only returns the main icon, i think the problem with
> the animation of the action icons is elsewhere...

ok, played with the code some more this morning (rather than going from 
memory, which oddly isn't as good as disks at storing this flawlessly ;) ... 
Phase is called from IconAction::show(), which means that IconAction's update 
should be being called. however, IconAction is no longer a QGraphicsItem on 
its own. it's just a data class now and all the painting happens in Icon. so 
the Phase stuff needs to move to Icon and probably all the show() and hide() 
stuff in IconAction can just go away. it breaks encapsulation somewhat which 
is unfortunate but at least it will work...

i'm about to head into the shower but will do this next.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080101/2f42040b/attachment.pgp