[Panel-devel] [PATCH] tooltips + taskbar thumbnails

[Aaron J. Seigo]

On Friday 28 December 2007, Jason Stubbs wrote:
> Hmm... After taking a closer look, I can't see how to do this without
> permanently allocating the QActions.

libtaskmanager should probably just provide a couple of QAction factories and 
the caller needs to manage their lifespan.

> At best, the QActions could be 
> allocated the first time a context menu is shown.

sure; this is really up to the consumer afaic.

> I'm also not sure what 
> should be done with the QActions of a menu that represents multiple tasks.

there's already code to handle such a thing in TaskRMBMenu; essentially the 
actions change depending on whether or not there are multiple tasks.

> A throw away menu is much easier...

but not correct, imho, as it introduces inconsistencies in the api =) it also 
ties us to a menu representation which certainly is an assumption we should 
try our best to avoid.

stepping back from it for a moment ... i can understand why the menu is in 
libtaskmanager (share the code and keep the menus consistent) but it's just 
such a difficult place for it to be as it makes a very incorrect assumption 
that it's the actual menu itself which isn't going to always be the case.

the real hassle here is that there are submenus to the context menu, e.g. 
Advanced. otherwise it'd be pretty straightforward. i suppose we can sort of 
hack around this with action sets for both the main menu and advanced? still 
leaves us with the problem of getting that hierarchy back to libplasma.. 
hm... need to think about this some more.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080101/ef8cb54a/attachment.pgp