Review Request: Kickoff: Make it freely resizable

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/228/#review208
-----------------------------------------------------------


awesome; this is a long wanted feature. thanks!

there are a few issues below, i'll help make them solvable by making Launcher aware of the applet so that it can be used.



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://mattr.info/r/228/#comment151>

    this is wrong. it should be using the applet's config. of course, Launcher doesn't know about the applet. i'll fix that right now, and then you can do m_applet->config() instead.



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://mattr.info/r/228/#comment153>

    doing this in the hideEvent is really wasteful. it should happen in the mouseReleaseEvent instead.



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
<http://mattr.info/r/228/#comment152>

    never call sync() in plasma. instead emit the applet's configNeedsSaving signal.


- Aaron


On 2008-02-27 09:07:39, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/228/
> -----------------------------------------------------------
> 
> (Updated 2008-02-27 09:07:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Implements wish 152052, needed: a good graphic for the resize handle
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
> 
> Diff: http://mattr.info/r/228/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>