[PATCH] make panel not use "size" config entry

[Chani]

On February 27, 2008 00:29:50 Aaron J. Seigo wrote:
> On Tuesday 26 February 2008, Chani wrote:
> > sorry I'm not using review board, I have to run offline.
> > this patch removes the need for a "size" config entry in a less ugly way
> > by reading the geometry and location instead.
>
> someone remind me why we're even storing the width/height in m_size at all
> rather than just using the width/height of size() directly?

yeah, it should die someday, but it makes the config dialog easier right now, 
and ensures we keep the same content 'size' when switching between horizontal 
and vertical without needing too much thought.
I decided to get it out of the config file first, then play around with fully 
removing it later. although... now that I think about it, having it in the 
config file doesn't really *hurt* anything because it's just duplicate 
information. it's silly but won't cause any headaches for us, so no need for 
me to rush.

>
> also, i think the change from constraintsUpdated() to updateSize() when the
> config is accepted is incorrect.

from updateConstraints(), you mean.
hrrm. actually, I think it makes no difference right now.
configAccepted() blindly sets m_size and the location. it really shouldn't set 
the location unless it changes - but it should probably set the actual size 
when there's a size change, not just m_size - and I think it really should 
call updateConstraints with only the ones that actually changed.

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080227/5a94b01e/attachment.pgp