Review Request: Task items update on theme change

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/222/#review199
-----------------------------------------------------------

Ship it!


sort of sucks that we need to do this for each applet; walking the child tree and calling update is perhaps a bit overkill as well, though. hum.

it seems that QGraphicsWidget, with the PaletteChange event, may help solve this problem nicely ...

anyways, for this patch, looks good. pls commit (i'll leave this one to you; apply for your svn account and then you can commit yourself =)

- Aaron


On 2008-02-26 01:47:33, Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/222/
> -----------------------------------------------------------
> 
> (Updated 2008-02-26 01:47:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch updates the task items in the tasks applet on a theme change (including on a system color change for color-aware plasma themes).  
> 
> I had hoped to get the systray and icon applets fixed as well but wasn't able to figure out why they were not updating as expected.  Maybe someone with greater skills than me (wouldn't take much...) can tackle them.  This gets me 95% of what I needed to start working on some ideas for plasma themes.  Thanks so much for being so welcoming and accomodating.
> 
> As usual, I do not have commit priveleges so if/when this passes review, please feel free to commit.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp
> 
> Diff: http://mattr.info/r/222/diff
> 
> 
> Testing
> -------
> 
> Tested with Aya plasma theme (http://www.mediafire.com/?ypymct3nco5) which responds to system color changes.
> 
> 
> Thanks,
> 
> Andrew
> 
>