Review Request: Update on system color change

Andrew Lake jamboarder at yahoo.com
Tue Feb 26 05:58:57 CET 2008



> On 2008-02-24 21:27:09, Aaron Seigo wrote:
> > this will cause a flury of disk activity for the svg's in play (though no unnecessary re-rendering) but i don't see an easy way around that. so ... commit away.
> 
> Andrew Lake wrote:
>     Great! No commit privileges here, so anyone who does should feel free to commit this.  (I'll try to remember to include this information in the review request in future.)

Could someone with commit privileges commit this patch please?  It would really be appreciated.  Thanks much.  Let me know if I should provide a fresh diff.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/216/#review189
-----------------------------------------------------------


On 2008-02-24 20:20:48, Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/216/
> -----------------------------------------------------------
> 
> (Updated 2008-02-24 20:20:48)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch causes displayed applets to update when the system color scheme changes (when no "colors" file is supplied with the theme).
> 
> Since Plasma::Theme is the component that decides whether to use the system colors or use the colors scheme supplied with the theme, it seemed appropriate for it to do this.  This patch gets us most of the way there.  A couple stubborn applets remain (tasks, system tray), but I figure I'll try to picked those off one at a time.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
> 
> Diff: http://mattr.info/r/216/diff
> 
> 
> Testing
> -------
> 
> Tested with Aya plasma theme (http://www.mediafire.com/?ypymct3nco5) which responds to system color changes.
> 
> 
> Thanks,
> 
> Andrew
> 
>



More information about the Panel-devel mailing list