Review Request: update animators use of QPainter()

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/217/#review191
-----------------------------------------------------------


the begin/end is right, but setting the composition mode should stay. it works for non-QImages, though support varies depending on the QPainter backend. in the future that may extend to further usefulness, so leave those as is.


- Aaron


On 2008-02-24 21:58:44, Bill Egert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/217/
> -----------------------------------------------------------
> 
> (Updated 2008-02-24 21:58:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> -This constructor is convenient for short-lived painters and should be used only once. The constructor calls begin() for you and the QPainter destructor automatically calls end().
> 
> -Warning: You can only set the composition mode for QPainter objects that operates on a QImage.
> 
> Or at least this is what trolltech says :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/animators/default/defaultAnimator.cpp
> 
> Diff: http://mattr.info/r/217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill
> 
>