Review Request: Update on system color change

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/216/#review189
-----------------------------------------------------------

Ship it!


this will cause a flury of disk activity for the svg's in play (though no unnecessary re-rendering) but i don't see an easy way around that. so ... commit away.

- Aaron


On 2008-02-24 20:20:48, Andrew Lake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/216/
> -----------------------------------------------------------
> 
> (Updated 2008-02-24 20:20:48)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch causes displayed applets to update when the system color scheme changes (when no "colors" file is supplied with the theme).
> 
> Since Plasma::Theme is the component that decides whether to use the system colors or use the colors scheme supplied with the theme, it seemed appropriate for it to do this.  This patch gets us most of the way there.  A couple stubborn applets remain (tasks, system tray), but I figure I'll try to picked those off one at a time.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
> 
> Diff: http://mattr.info/r/216/diff
> 
> 
> Testing
> -------
> 
> Tested with Aya plasma theme (http://www.mediafire.com/?ypymct3nco5) which responds to system color changes.
> 
> 
> Thanks,
> 
> Andrew
> 
>