Review Request: Use QRectF() instead of QRect() where it seems more appropriate.

Aaron Seigo aseigo at kde.org
Sun Feb 24 19:41:22 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/196/#review182
-----------------------------------------------------------

Ship it!


looks great; who could say no to more F'ing?

- Aaron


On 2008-02-24 12:30:01, Bill Egert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/196/
> -----------------------------------------------------------
> 
> (Updated 2008-02-24 12:30:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> -Use QRectF() instead of QRect() where it seems more appropriate.
> -some clean-up.
> 
> Alternative Summary: Less casting, more F-ing
> 
> :P
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/itemdelegate.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/searchbar.cpp
>   /trunk/KDE/kdebase/workspace/plasma/tools/plasmoidviewer/fullview.cpp
> 
> Diff: http://mattr.info/r/196/diff
> 
> 
> Testing
> -------
> 
> Tested all applets in plasmoidveiwer.  Quit/restarted plasma.  Everything looks ok to me.
> 
> 
> Thanks,
> 
> Bill
> 
>



More information about the Panel-devel mailing list