Review Request: Fading hover on desktop icons

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/195/#review181
-----------------------------------------------------------

Ship it!


i like it, i see not it also reacts to theme change, good :D.
only one little thing: maybe i would still enable the hover effect when the icon has no background, otherwise is unnoticeable


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon.cpp
<http://mattr.info/r/195/#comment125>

    here i would put 
    if (!result.isNull() && useHoverEffect && !drawBg) {
    
    (here with this patch the hover effect is always on!)


- Marco


On 2008-02-24 09:56:21, Sebastian Kuegler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/195/
> -----------------------------------------------------------
> 
> (Updated 2008-02-24 09:56:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make icons fade on hover rather than abrupt highlighting
> 
> I'm removing KIconEffect here since it's not in sync with this animation and the animation provides enough visual hinting to notice the hover.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/icon_p.h
> 
> Diff: http://mattr.info/r/195/diff
> 
> 
> Testing
> -------
> 
> Running with this for some days, no visible problems
> 
> 
> Thanks,
> 
> Sebastian
> 
>