Review Request: Color scheme aware plasma theming

[Aaron J. Seigo]

On Thursday 21 February 2008, Andrew Lake wrote:
> The result is that with the current diff, the svgs don't repaint until the
> Applet otherwise decides it needs to repaint (mouseover, click or some
> other signal).  So here's what I propose:  A new bool in Plasma::Theme to
> keep track of whether theme is using the system color scheme or the color
> scheme supplied with the theme. A colorsChanged() slot in applets that will
> update() when the system color changes.  The slot would only be connected
> if the new theme bool says it's using system colors.

that sounds completely sane to me. =)

> If this sounds reasonable I'll update the diff with the changes for review.
>  I can also submit that as a separate review if you prefer since the svg
> part is basically done.

sure; why don't you commit the svg changes first, mark that review request as 
submitted and then do another one for colorsChanged() slot in Plasma::Applet.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080221/01a5ab65/attachment.pgp