Review Request: move sceneEventFilter and mouseMoveEvent from icon to applet

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/167/#review162
-----------------------------------------------------------

Ship it!


minor whitespace changes, otherwise ready to go =)


/trunk/KDE/kdebase/workspace/libs/plasma/applet.h
<http://mattr.info/r/167/#comment115>

    there shouldn't be spaces after or before the ()s (i know, this file is inconsistent ... but new code should adhere to the coding style)



/trunk/KDE/kdebase/workspace/libs/plasma/applet.cpp
<http://mattr.info/r/167/#comment116>

    watch the spacing here as well =)
    
    otherwise looks good...


- Aaron


On 2008-02-20 13:39:00, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/167/
> -----------------------------------------------------------
> 
> (Updated 2008-02-20 13:39:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is a transplant of sceneEventFilter and mouseMoveEvent implementations from the icon applet to the applet class as discussed on plasma-devel a while ago, could save some duplicate code on applets that have widgets that must be able to both manage mouse clicks and being dragged around
> to use this one must do in the applet widget->installSceneEventFilter(this) on every needed widget.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/applet.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/applet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.cpp
> 
> Diff: http://mattr.info/r/167/diff
> 
> 
> Testing
> -------
> 
> tested with icon applet and with the trashcan
> it works, but it's not possible to drag icons from desktop to the panel (as it reimplements a piece of the hande, it was so also before)
> 
> 
> Thanks,
> 
> Marco
> 
>