Review Request: News applet's configuration dialog modified to allow configuration of multiple feeds.
Petri Damstén
petri.damsten at dnainternet.net
Tue Feb 19 08:50:15 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/129/#review153
-----------------------------------------------------------
Ship it!
Looks ok to me.
- Petri
On 2008-02-13 18:19:45, Rob Scheepmaker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/129/
> -----------------------------------------------------------
>
> (Updated 2008-02-13 18:19:45)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> I've recently improved the RSS dataengine with support for multiple feeds (review pending: http://70.136.65.72/r/111/)
> This diff allows the news applet to actually make use of this, by changing the configuration dialog. I've also fixed some indentation issues.
>
>
> Diffs
> -----
>
> trunk/playground/base/plasma/applets/news/config.ui
> trunk/playground/base/plasma/applets/news/news.h
> trunk/playground/base/plasma/applets/news/news.cpp
>
> Diff: http://mattr.info/r/129/diff
>
>
> Testing
> -------
>
> Tested with a couple of feeds. Most seems to work fine. The applet seems to have issues with mixing feeds with and without timestamps, I haven't looked into why this happens yet. Also the first update from the dataengine is incomplete.
>
>
> Thanks,
>
> Rob
>
>
More information about the Panel-devel
mailing list