Review Request: RSS dataengine now supports multiple feeds.

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/111/#review151
-----------------------------------------------------------

Ship it!


Propably have to modify this after Plasma::Service is ready.

- Petri


On 2008-02-13 18:21:42, Rob Scheepmaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/111/
> -----------------------------------------------------------
> 
> (Updated 2008-02-13 18:21:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> My first contribution to the KDE project! This diff should add support for requesting a comma separated list of multiple feeds from the RSS dataengine, which will merge the entries from the different feeds in one convenient time sorted list. I'm really new to QT / plasma, so I've probably done some things wrong... so I'm looking forward to getting feedback from people who actually know what they're doing. ;)
> I've updated the diff, making the indentation consistent, and letting the engine create only one source (the one requested), since creating unrequested sources could lead to complications... To avoid the increase in bandwidth if an applet wants to, say, display both a combined list and a list containing only a single feed, the dataengine caches individual RSS feeds for one minute (the minimum update time). This time should maybe depend on the interval?
> I've fixed a bug I discovered: multiple items with the same timestamp were overwriting each other.
> 
> 
> Diffs
> -----
> 
>   trunk/playground/base/plasma/engines/rss/rss.h
>   trunk/playground/base/plasma/engines/rss/rss.cpp
> 
> Diff: http://mattr.info/r/111/diff
> 
> 
> Testing
> -------
> 
> Not a lot atm. I've tested with both plasmaengineexplorer and the news applet in trunk. Feeding the news applet in trunk with a comma seperated list of url's shows that it works! Data abstraction rocks :). It seems however that the first time the data is requested, the feeds aren't really merged... the next update works fine. I'm still looking into that.
> 
> 
> Thanks,
> 
> Rob
> 
>