Review Request: Decibel presence Data Engine
Aaron Seigo
aseigo at kde.org
Sun Feb 17 10:01:45 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/142/#review138
-----------------------------------------------------------
Ship it!
you don't need to reimplement sourceRequested if at all it does is return false; the default implementation in DataEngine already does this.
i can help with a FindDecibel.module this coming week if it hasn't already been done elsewhere.
also, for things like full components you don't need to post them to RB here; just put them directly into playground/base/plasma/ and work on them there. you can announce their availability on panel-devel.
cool stuff, though. amazing how little code it takes =)
- Aaron
On 2008-02-16 02:09:21, George Goldberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/142/
> -----------------------------------------------------------
>
> (Updated 2008-02-16 02:09:21)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch adds a data engine that provides presence information for the user from decibel.
>
>
> Diffs
> -----
>
> trunk/playground/base/plasma/engines/CMakeLists.txt
> trunk/playground/base/plasma/engines/presence/CMakeLists.txt
> trunk/playground/base/plasma/engines/presence/plasma-dataengine-presence.desktop
> trunk/playground/base/plasma/engines/presence/presence.h
> trunk/playground/base/plasma/engines/presence/presence.cpp
>
> Diff: http://mattr.info/r/142/diff
>
>
> Testing
> -------
>
> Compiled and tested with current decibel SVN.
>
>
> Thanks,
>
> George
>
>
More information about the Panel-devel
mailing list