Review Request: Add a theme selector to the "Configure Desktop" dialog

Andre Duffeck duffeck at kde.org
Fri Feb 15 11:23:59 CET 2008



> On 2008-02-15 03:32:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp, lines 664-666
> > <http://mattr.info/r/138/diff/1/#file342line664>
> >
> >     Plasma::Theme::setThemeName takes care of writing the setting out to the config file. you shouldn't need to do that yourself.

... i wonder why i missed that :)


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/138/#review134
-----------------------------------------------------------


On 2008-02-15 02:43:54, Andre Duffeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/138/
> -----------------------------------------------------------
> 
> (Updated 2008-02-15 02:43:54)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a theme selector to the "Configure Desktop" dialog (until there is a better place for it).
> 
> Requires http://mattr.info/r/136/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/BackgroundDialog.ui
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.h
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp
> 
> Diff: http://mattr.info/r/138/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://mattr.info/r/138/s/9/
> 
> 
> Thanks,
> 
> Andre
> 
>



More information about the Panel-devel mailing list