Review Request: Better standard Size for BackgroundDialog

[Aaron Seigo]

> On 2008-02-13 09:28:00, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp, line 443
> > <http://mattr.info/r/127/diff/1/#file314line443>
> >
> >     arbitrary sizes scare me ;) changes in fonts, language used, etc probably don't work well with this i'd imagine.
> >     
> >     getting rid of the blank space probably involves messing with the widget layout.
> 
> Lukas  Appelhans wrote:
>     Hey,
>     I've done a new patch...
>     
>     Lukas

this one looks ok in designer. once i can test in plasma itself i'll give it the thumbs up.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/127/#review118
-----------------------------------------------------------


On 2008-02-13 12:18:21, Lukas  Appelhans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/127/
> -----------------------------------------------------------
> 
> (Updated 2008-02-13 12:18:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hi!
> This patch sets a better standard Size for the Background-Dialog and removes the empty-space :)
> 
> Lukas
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/BackgroundDialog.ui
> 
> Diff: http://mattr.info/r/127/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukas
> 
>